Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation block scheduler #319

Merged
merged 28 commits into from
Sep 13, 2023
Merged

Validation block scheduler #319

merged 28 commits into from
Sep 13, 2023

Conversation

cyberphysic4l
Copy link
Contributor

@cyberphysic4l cyberphysic4l commented Aug 31, 2023 •
edited
Loading

Implementation of the validation block scheduler described in this Google doc.

Inludes fixed rate of CommitteeSize x ValidationBlocksPerSlot and for each validator. penalty of PunishmentEpochs epochs worth of Mana generation from the validator's stake for each block issued over the ValidationBlocksPerSlot.

closes #236

closes #338

@cyberphysic4l cyberphysic4l mentioned this pull request Sep 7, 2023
Merged
@cyberphysic4l cyberphysic4l marked this pull request as ready for review September 7, 2023 09:10
piotrm50
piotrm50 requested changes Sep 8, 2023
View reviewed changes
pkg/protocol/engine/congestioncontrol/scheduler/drr/scheduler.go Outdated Show resolved Hide resolved
pkg/protocol/engine/congestioncontrol/scheduler/drr/scheduler.go Show resolved Hide resolved
pkg/protocol/engine/congestioncontrol/scheduler/drr/scheduler.go Outdated Show resolved Hide resolved
pkg/protocol/engine/congestioncontrol/scheduler/drr/scheduler.go Show resolved Hide resolved
pkg/protocol/engine/congestioncontrol/scheduler/drr/scheduler.go Outdated Show resolved Hide resolved
pkg/protocol/engine/congestioncontrol/scheduler/drr/scheduler.go Outdated Show resolved Hide resolved
pkg/protocol/engine/congestioncontrol/scheduler/drr/validatorqueue.go Show resolved Hide resolved
pkg/protocol/engine/congestioncontrol/scheduler/drr/validatorqueue.go Show resolved Hide resolved
piotrm50
piotrm50 reviewed Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@piotrm50 piotrm50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from one question I had about changes to the filter. I will approve after clarifying that.

Before merging please make sure that it runs in Docker network correctly.

@cyberphysic4l cyberphysic4l merged commit 83057da into develop Sep 13, 2023
5 checks passed
@cyberphysic4l cyberphysic4l deleted the feat/validation-scheduler branch September 13, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrm50 piotrm50 piotrm50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Penalize over-issuing validators Scheduler for validation blocks
3 participants
@cyberphysic4l @piotrm50 @jkrvivian