Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tests for the rewards calculations #368

Closed
oliviasaa opened this issue Sep 26, 2023 · 0 comments · Fixed by #530
Closed

New tests for the rewards calculations #368

oliviasaa opened this issue Sep 26, 2023 · 0 comments · Fixed by #530
Assignees
@oliviasaa
Milestone
v1.0.0-beta

Comments

@oliviasaa
Copy link
Contributor

oliviasaa commented Sep 26, 2023 •
edited
Loading

the tests for the rewards calculation are not that extensive, we should write new ones. Also, it's a good idea to compare results with the ones resulting from floating point operations
@karimodm karimodm added this to the 1.0 RC milestone Oct 9, 2023
@karimodm karimodm moved this to Backlog in iota-core Oct 9, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in iota-core Nov 19, 2023
@karimodm karimodm linked a pull request Nov 28, 2023 that will close this issue
includes a test comparing rewards to float results #530
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliviasaa oliviasaa

Labels
None yet
Projects
iota-core
Archived in project
Milestone
v1.0.0-beta
Development

Successfully merging a pull request may close this issue.

includes a test comparing rewards to float results iotaledger/iota-core
2 participants
@karimodm @oliviasaa