From 7b131303d7722c9142394bf1f205073176bd80ff Mon Sep 17 00:00:00 2001 From: Hans Moog <3293976+hmoog@users.noreply.github.com> Date: Mon, 6 Nov 2023 22:50:42 +0100 Subject: [PATCH] Refactor: addressed comments --- pkg/protocol/engine/booker/inmemorybooker/booker.go | 2 +- .../engine/commitmentfilter/accountsfilter/commitmentfilter.go | 2 +- .../engine/congestioncontrol/scheduler/passthrough/scheduler.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/protocol/engine/booker/inmemorybooker/booker.go b/pkg/protocol/engine/booker/inmemorybooker/booker.go index 51f53c52d..817b1c2cb 100644 --- a/pkg/protocol/engine/booker/inmemorybooker/booker.go +++ b/pkg/protocol/engine/booker/inmemorybooker/booker.go @@ -117,7 +117,7 @@ func (b *Booker) Queue(block *blocks.Block) error { } // Reset resets the component to a clean state as if it was created at the last commitment. -func (b *Booker) Reset() {} +func (b *Booker) Reset() { /* nothing to reset but comply with interface */ } func (b *Booker) Shutdown() { b.TriggerStopped() diff --git a/pkg/protocol/engine/commitmentfilter/accountsfilter/commitmentfilter.go b/pkg/protocol/engine/commitmentfilter/accountsfilter/commitmentfilter.go index 589cbf23b..842f06c61 100644 --- a/pkg/protocol/engine/commitmentfilter/accountsfilter/commitmentfilter.go +++ b/pkg/protocol/engine/commitmentfilter/accountsfilter/commitmentfilter.go @@ -191,7 +191,7 @@ func (c *CommitmentFilter) evaluateBlock(block *blocks.Block) { } // Reset resets the component to a clean state as if it was created at the last commitment. -func (c *CommitmentFilter) Reset() {} +func (c *CommitmentFilter) Reset() { /* nothing to reset but comply with interface */ } func (c *CommitmentFilter) Shutdown() { c.TriggerStopped() diff --git a/pkg/protocol/engine/congestioncontrol/scheduler/passthrough/scheduler.go b/pkg/protocol/engine/congestioncontrol/scheduler/passthrough/scheduler.go index 1f46884b3..f85b9fd21 100644 --- a/pkg/protocol/engine/congestioncontrol/scheduler/passthrough/scheduler.go +++ b/pkg/protocol/engine/congestioncontrol/scheduler/passthrough/scheduler.go @@ -73,4 +73,4 @@ func (s *Scheduler) AddBlock(block *blocks.Block) { } // Reset resets the component to a clean state as if it was created at the last commitment. -func (s *Scheduler) Reset() {} +func (s *Scheduler) Reset() { /* nothing to reset but comply with interface */ }