Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sd-jwt-payload dependency #1296

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Update sd-jwt-payload dependency #1296

merged 4 commits into from
Feb 6, 2024

Conversation

abdulmth
Copy link
Contributor

@abdulmth abdulmth commented Feb 5, 2024 •
edited
Loading

Update the dependency sd-jwt-payload to the version 0.2.0 and adapt its Wasm bindings.

@abdulmth abdulmth requested a review from a team as a code owner February 5, 2024 19:49
@abdulmth abdulmth self-assigned this Feb 5, 2024
@abdulmth abdulmth added the Chore Tedious, typically non-functional change label Feb 5, 2024
@abdulmth abdulmth added this to the v1.1 milestone Feb 5, 2024
@abdulmth abdulmth added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Feb 5, 2024
@abdulmth abdulmth added the No changelog Excludes PR from becoming part of any changelog label Feb 5, 2024
@abdulmth abdulmth requested a review from eike-hass February 6, 2024 10:48
eike-hass
eike-hass approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@eike-hass eike-hass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you provide a more complete title and description so it can serve a reference through the changelog?

@eike-hass eike-hass added Added A new feature that requires a minor release. Part of "Added" section in changelog and removed Chore Tedious, typically non-functional change No changelog Excludes PR from becoming part of any changelog labels Feb 6, 2024
@abdulmth abdulmth changed the title Update sd-jwt-payload Update sd-jwt-payload dependency Feb 6, 2024
@abdulmth abdulmth added No changelog Excludes PR from becoming part of any changelog and removed Added A new feature that requires a minor release. Part of "Added" section in changelog labels Feb 6, 2024
@abdulmth
Copy link
Contributor Author

abdulmth commented Feb 6, 2024

@eike-hass I updated the description. But I don't think this PR should be included in the Changelog, since it's part of introducing the SD-JWT feature to the 1.1 release.

@abdulmth abdulmth merged commit 1a030d5 into main Feb 6, 2024
18 checks passed
@abdulmth abdulmth deleted the chore/update-sd-jwt branch February 6, 2024 13:31
@eike-hass eike-hass added Added A new feature that requires a minor release. Part of "Added" section in changelog and removed No changelog Excludes PR from becoming part of any changelog labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UMR1352 UMR1352 UMR1352 approved these changes

@eike-hass eike-hass eike-hass approved these changes

Assignees

@abdulmth abdulmth

Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
IOTA Identity - Framework Developments
Status: Done
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@abdulmth @eike-hass @UMR1352