Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup Box #7240

Merged
merged 7 commits into from
Aug 29, 2023
Merged

refactor: cleanup Box #7240

merged 7 commits into from
Aug 29, 2023

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #7239

Changelog

- Cleanup Box

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda requested a review from cpl121 August 23, 2023 14:53
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be changes in the following places:

The search box now looks weird
image
Original:
image

Same thing happens to amount input in the filters, and the change profile name in settings.

Tabs in node information (settings) looks weird too: (PR)
image
(Original)
image

And password inputs
image

@evavirseda evavirseda requested review from VmMad and cpl121 August 24, 2023 11:50
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few changes, so that the component is cleaned up a little more

packages/shared/components/boxes/Box.svelte Outdated Show resolved Hide resolved
@evavirseda evavirseda requested a review from VmMad August 25, 2023 16:39
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason the amount filter looks bigger now
image
image

@evavirseda evavirseda requested a review from VmMad August 28, 2023 14:45
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to go

@begonaalvarezd begonaalvarezd merged commit 2ef97ea into develop Aug 29, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the refactor/cleanup-boxes branch August 29, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Cleanup Box
4 participants