Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Update transaction options for claiming actions #8474

Closed
begonaalvarezd opened this issue Apr 26, 2024 · 0 comments · Fixed by #8476
Closed

[Task]: Update transaction options for claiming actions #8474

begonaalvarezd opened this issue Apr 26, 2024 · 0 comments · Fixed by #8476
Assignees

Comments

@begonaalvarezd
Copy link
Member

Task description

At the moment, the claiming actions put the resulting outputs owned by the ed25519 address instead of the account. The SDK is adding support for custom transaction options for us to pass the custom address (account deposit addr) to be set when claiming. We should apply this everywhere it happens, for now I know that claimingNFTs lead to this behavior, we should review the all the transactions to make sure it doesnt happen (eg native tokens, ...)
Blocked by iotaledger/iota-sdk#2237

@begonaalvarezd begonaalvarezd moved this from 📋 Backlog to 🔖 Todo in Firefly - Task Management Apr 26, 2024
@begonaalvarezd begonaalvarezd moved this from 🔖 Todo to 🚫 Blocked in Firefly - Task Management Apr 26, 2024
@marc2332 marc2332 self-assigned this Apr 29, 2024
@begonaalvarezd begonaalvarezd moved this from 🚫 Blocked to 🏗 In Progress in Firefly - Task Management Apr 29, 2024
@marc2332 marc2332 linked a pull request Apr 30, 2024 that will close this issue
@marc2332 marc2332 moved this from 🏗 In Progress to 👀 Needs Review in Firefly - Task Management Apr 30, 2024
@cpl121 cpl121 moved this from 👀 Needs Review to ✅ PR Approved in Firefly - Task Management May 3, 2024
@github-project-automation github-project-automation bot moved this from ✅ PR Approved to 🎉 Done in Firefly - Task Management May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging a pull request may close this issue.

2 participants