-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Error defining custom network when the wallet is connected #15
Comments
Hi @jorgemmsilva, thanks for reporting this error. I feel like the form doesnt have the right label, where it says "network url" is where the rpc url goes wdyt? would renaming the label be enough or are you referring to something else? |
renaming that would be nice, I agree. But the main issue stands, if you're connected to the testnet with a wallet and try to set a new custom network without a rpc url, it will error and not let you |
|
🤷 but why not just save the custom network anyway? as it stands the modal just keeps opened for no reason. |
I dont think that saving something that is not complete or correct is right. In this case, because the form validation is not succesful it doesnt get saved, hence the popup doesnt close, it is not great UX closing an reseting form popups when the action didnt succeed because you will need to open it again and fill it again to complete it correctly |
It works perfectly if you're not connected, that field is not even mandatory... |
Bug description
when wallet is connected, if you try to save a new custom network, it will fail with:
Expected behavior
it should disconnect the wallet instead of erroring.
Furthermore:
Can the issue reliably be reproduced?
Yes
The text was updated successfully, but these errors were encountered: