Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PATCH for Kubernetes clusters and node pool updates #4

Open
avorima opened this issue Nov 11, 2020 · 2 comments
Open

Add PATCH for Kubernetes clusters and node pool updates #4

avorima opened this issue Nov 11, 2020 · 2 comments
Assignees
@LiviusP
Labels
enhancement New feature or request

Comments

@avorima
Copy link

avorima commented Nov 11, 2020

Current SDK Version

v5.2.0

Use-cases

The Kubernetes cluster and node pool update actions use PUT like PATCH, so it would make sense to actually use PATCH.

Attempted Solutions

Proposal

References

https://tools.ietf.org/html/rfc7231#section-4.3.4

https://tools.ietf.org/html/rfc5789#section-2
@avorima avorima added the enhancement New feature or request label Nov 11, 2020
@mflorin
Copy link
Contributor

mflorin commented Dec 18, 2020

Hello @avorima,

This actually depends on the Cloud API providing the PATCH request.
For now, only a PUT request is provided for updating a node pool.
As soon as PATCH is available, we will use it in our sdk.

Thanks,
Florin

@cristiGuranIonos
Copy link
Contributor

Still no patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LiviusP LiviusP

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mflorin @LiviusP @avorima @cristiGuranIonos