Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default RoslynSourceText #1938

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Sep 27, 2023

WHAT

🤖 Generated by Copilot at 330b861

This pull request adds an experimental feature to use RoslynSourceText for the F# language service, which can be enabled by setting FSharp.fsac.sourceTextImplementation in the configuration. It also fixes a typo in release/package.json.

🤖 Generated by Copilot at 330b861

To make the language service faster
We use RoslynSourceText as a master
We also fix a typo
In the package.json file
And FSharp.fsac.sourceTextImplementation we no longer plaster

✨🔧✏️

WHY

Corresponding PR to ionide/FsAutoComplete#1168

HOW

🤖 Generated by Copilot at 330b861

  • Implement RoslynSourceText feature to improve language service performance and memory usage (link, link)
  • Update default value and description of FSharp.fsac.sourceTextImplementation option in package.json to use RoslynSourceText (link)
  • Use configuration value of FSharp.fsac.sourceTextImplementation in getOptions function in LanguageService.fs instead of hard-coded string (link)
  • Fix typo by removing extra newline at the end of package.json (link)

@TheAngryByrd TheAngryByrd force-pushed the default-roslynsourcetext branch from ac75b97 to 4913c94 Compare September 27, 2023 23:48
@TheAngryByrd TheAngryByrd merged commit e8228f5 into ionide:main Sep 28, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants