New architecture support (status: v9.1.2 should work, headlessJS needs general upstream fix in react-native)

[elsa17z]

Discussed in #795

^{Originally posted by ravindraguptacapgemini June 13, 2023}
Need to know if library support new architecture of React Native with Fabric and Turbo Module.

Currently this module will not work with react-native in new architecture mode, bridgeless or otherwise.

The first step is to get it working in bridgeless mode at minimum. These issues block that:

• Android events not working in bridgeless mode Android: onForegroundEvent not listening to onPress Event #621 (comment) (note: fix requires RN >= 74 for ReactHost symbol - RN >= 73 DefaultNewArchitectureEntryPoint symbol)
• Android headlessJS not working in bridgeless mode and will not work on RN76 until a fix is picked
  • Upstream issue - pick request to RN76: [0.76] Android New Arch HeadlessJsTaskService EventEmitter Fix reactwg/react-native-releases#581
  • Another upstream issue - pick request to 0.76.2 [0.76,2] Fix HeadlessJsTaskService SetTimeout reactwg/react-native-releases#617
• Investigate [report of android foreground service not working on react-native 0.76.1] (New architecture support (status: v9.1.2 should work, headlessJS needs general upstream fix in react-native) #1077 (comment)) - may be Foreground service freezes when app dismissed #1078 - may not, unsure
• another upstream issue with headlessJS still in 0.76.1 and likely not fixed in time to make 0.76.2 either HeadlessTask: Could not enqueue microtask because they are disabled in this runtime facebook/react-native#47570

Update status here when complete: https://reactnative.directory/?search=%40notifee%2Freact-native

[mikehardy]

Just chatted with the ever-benevolent (I mean that!) overlords @ Invertase and I can check this repo for RN76 compat, so I'll have a go myself but I will always welcome information + help + advice from anyone else so please chime in if you are reading this and you're looking at it too. Hopefully it's easy!

[mikehardy]

This is supposed to be fixed in react-native 0.76.1, it needs a retest to see if background handling works again with new architecture. It may take me some time to get a suitable reproduction environment set up and I would welcome anyone to post success or failure on 0.76.1 if they are able to test this before I get to it.

[netdown]

I've just upgraded to 0.76.1 and foreground service does not work with new arch. It works while the app is opened, but gets stuck if I close it. No error messages, I haven't digged it up.

[mikehardy]

That's surprising! That's worse than I was hoping to hear 😆 . I want to put a sad face or a thumbs-down reaction on your comment but it's the content, not for you as a messenger of course @netdown.

Were you able to test if headlessJS works? As that is a separate issue from foreground service

I'll add foreground service testing to the status list above.

[netdown]

I use foreground service only.

[InSaine2k13]

Same issue @netdown my foreground service freezes completely on new architecture once the app is out of focus

[lovegaoshi]

at RNTP which also uses headlessJsTaskService, I believe my issue has the same root to what you have. my patch seems to work when app is minimized and/or resumed, but now I'm noticing the Js code executed on event listening does not complete fetch requests. I'm opening an issue in the discussion group in case anyone is interested.

---

i have a better understanding of the issue i had - setTimeout will cause problems when app is minimized and resumed, as clearFrameCallback will only be called when there is no active headlessJsTask, and setTimeout lingering will simply fail after onHostResume it seems like. I have no idea why it worked with the old arch. and if I apply my "patch", all setTimeout will stop to function when app is minimized. Since whatwg-fetch uses a setTimeout with xhr.onLoad, it "breaks."

[mikehardy]

@lovegaoshi definitely interested and I read through the related information from RNTP with great interest earlier, I appreciate the cross-posting an the work you've put in to making headlessJS work on Fabric so far! Hopefully we all get through this in once piece 😆

[netdown]

@mikehardy Foreground service seems to be fine in 0.76.2! Probably fixed by facebook/react-native@ee7b4e2

[mikehardy]

Fantastic news! Now we just need background messages to work correctly per the latest one facebook/react-native#47570

We're getting there, bit by bit...