Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter selected implementation groups in table mode #960

Merged
merged 6 commits into from
Nov 14, 2024
Merged

filter selected implementation groups in table mode #960

merged 6 commits into from
Nov 14, 2024

Conversation

melinoix
Copy link
Contributor

fix : filter requirement assessments by selected implementation groups in table mode.

nas-tabchiche
nas-tabchiche approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@nas-tabchiche nas-tabchiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Mohamed-Hacene
Mohamed-Hacene reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be a solution to do it, however, we loose information by excluding basic requirements in the table mode which could be helpful to fill it. We should discuss about it before merging.

@Mohamed-Hacene Mohamed-Hacene marked this pull request as draft October 22, 2024 15:17
@Mohamed-Hacene Mohamed-Hacene marked this pull request as ready for review November 14, 2024 09:45
Mohamed-Hacene
Mohamed-Hacene approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0k

@Mohamed-Hacene Mohamed-Hacene merged commit e4cc3cd into main Nov 14, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mohamed-Hacene Mohamed-Hacene Mohamed-Hacene approved these changes

@nas-tabchiche nas-tabchiche nas-tabchiche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melinoix @nas-tabchiche @Mohamed-Hacene