Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript][enhancement]: Update typescript sample with the latest typescript definitions #99

Open
abisalehalliprasan opened this issue Oct 13, 2020 · 3 comments

Comments

@abisalehalliprasan
Copy link
Collaborator

Hacktoberfest is underway right now and we would love for you to contribute 🚀 . More information on #hacktoberfest is here

Develop-with-Intuit for Hacktoberfest

Problem

Update typescript sample with the latest typescript definitions index.d.ts file

Fix Needed

Update typescript sample with the latest typescript definitions and test the sample is working.

Instructions to use the sample app

In order to test the typings locally from the sample project, you'll need to link the intuit-oauth package with yarn or npm.

# Link local intuit-oauth branch with typings support to sample typescript project
yarn link
cd sample/typescript
yarn link intuit-oauth

PR Guidelines

Kindly follow the below instructions to submit your PR :

  • Fork and clone the repository (typescript branch).
  • Run npm install for dependencies.
  • Test all your changes.
  • Run npm test to execute all specs.

Once ready, please submit a PR to the typescript branch here.
Note : PR's will be merged to the master branch once all the testing is completed.

@100mik
Copy link

100mik commented Oct 18, 2020

Hey! I'd like to take a shot at this if it's fine.

@abisalehalliprasan
Copy link
Collaborator Author

@100mik : Awesome. That would be great. However, this issue/fix would be dependent on #100 ( as the sample should refer to the latest typings ).

I suggest you can start on this story once we start getting more updates on the #100. Does that sound good to you?

@100mik
Copy link

100mik commented Oct 19, 2020

Yes that's perfectly fine. I don't mind helping out if needed once the current assignee has taken a shot at #100
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants