We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In README code examples show:
const authResponse = await oauthClient.createToken(..); // or .refresh() or .refreshUsingToken(..) console.log('Token is', authResponse.json)
Instead it should be:
await oauthClient.createToken(..); // or .refresh() or .refreshUsingToken(..) console.log('Token is', oauthToken.token.getToken())
Reason is in 1st case createdAt is missing, and this is a big issue if you save that json without it
btw I think you should rather save only 1 field: expireAt field rather than 2: createdAt + expire_in
The text was updated successfully, but these errors were encountered:
Hi @caub , please help me find out where do you see this i.e. in which README file? I'll check and get this corrected. Thanks!
Sorry, something went wrong.
https://github.com/intuit/oauth-jsclient/blob/master/README.md?plain=1#L166 https://github.com/intuit/oauth-jsclient/blob/master/README.md?plain=1#L195 https://github.com/intuit/oauth-jsclient/blob/master/README.md?plain=1#L218 https://github.com/intuit/oauth-jsclient/blob/master/README.md?plain=1#L235
so maybe changing authResponse.json to oauthClient.token.getToken() or adding a note that it's recommended to save oauthClient.token.getToken()
oauthClient.token.getToken()
For revoke not sure it's needed
No branches or pull requests
In README code examples show:
Instead it should be:
Reason is in 1st case createdAt is missing, and this is a big issue if you save that json without it
btw I think you should rather save only 1 field: expireAt field rather than 2: createdAt + expire_in
The text was updated successfully, but these errors were encountered: