[@auto-it/npm] Invalid option --registry passed to lerna version

[AndrewLeedham]

Describe the bug

When upgrading to [email protected] they seem to be more strict about valid options. lerna version as called in auto therefore fails as --registry is an option of lerna publish but not lerna version.

To Reproduce

• Upgrade from [email protected] to [email protected] in a monorepo project.
• Run auto shipit.

Expected behavior

In theory [email protected] should be a clean upgrade, but because Auto is using an invalid option it fails.

Environment information:

"auto" version: v10.32.5
"git"  version: v2.30.1 (Apple Git-130)
"node" version: v14.18.1

Additional context

Error log:

Error: Running command 'npx' with args [lerna, version, major, --registry, https://registry.npmjs.org/, --yes, --no-push, --no-git-tag-version, --no-commit-hooks, --exact, --ignore-scripts] failed

ERR! lerna Unknown argument: registry

Code that adds the --registry flag seems to be here: https://github.com/intuit/auto/blob/main/plugins/npm/src/index.ts#L941

[AndrewLeedham]

I found a temporary workaround by specifying the registry as https://registry.npmjs.org in my lerna config. Since there is a check against the default which stops it from being added.

[FlomoN]

This workaround doesnt seem to work anymore, but i don't understand why.
I also tried adding (with and without trailing slash) to my lerna.json.

"command": {
    "publish": {
      "registry": "https://registry.npmjs.org"
    }
  }
}

Also in package.json

"publishConfig": {
    "registry": "https://registry.npmjs.org/"
  },

Still when I run npx auto shipit -d I get

‼  warning   lerna notice cli v5.5.0
lerna info versioning independent
lerna info Assuming all packages changed
lerna success found 2 packages ready to publish

‼  warning   lerna notice cli v5.5.0
lerna info versioning independent
lerna success found 2 packages

Error: Running command 'npx' with args [lerna, version, prepatch, --registry, https://registry.npmjs.org/, --yes, --no-push, --no-git-tag-version, --no-commit-hooks, --exact, --ignore-scripts, --preid, canary.523b477] 
failed

ERR! lerna Unbekanntes Argument: registry

Any idea?

[AndrewLeedham]

The defaulting code still seems to be there:

auto/plugins/npm/src/index.ts

Lines 250 to 255 in 0c96b56

	async function getRegistryArgs() {
	const registry = await getRegistry();
	return registry === DEFAULT_REGISTRY || !registry
	? []
	: ["--registry", registry];
	}

The registry is parsed as so, so either should work:

auto/plugins/npm/src/set-npm-token.ts

Lines 16 to 30 in 0c96b56

	export const getRegistry = async () => {
	const { publishConfig = {}, name } = await loadPackageJson();
	const lernaJson = isMonorepo() ? getLernaJson() : undefined;
	let registry;
	if (publishConfig.registry) {
	registry = publishConfig.registry;
	} else if (lernaJson?.command?.publish?.registry) {
	registry = lernaJson.command.publish.registry;
	} else if (name?.startsWith("@")) {
	const scope = name.split(`/`)[0];
	registry = registryUrl(scope);
	} else {
	registry = registryUrl();
	}

The default registry is "https://registry.npmjs.org"

auto/plugins/npm/src/set-npm-token.ts

Line 13 in 0c96b56

export const DEFAULT_REGISTRY = "https://registry.npmjs.org";

It seems to still be working for me, so I can only assume is isn't detecting the config for some reason?

[FlomoN]

Maybe its something about the --dry-run flag? When i run it without, it seems to work as expected.

[Webbanditten]

I'm having the same issue. Running --dry-run results in Unknown argument: registry

[uschtwill]

Observing the same behaviour.

[ryantang333]

For anyone still experiencing this issue, downgrading lerna to 3.0.0 is a workaround.

[hipstersmoothie]

Oooo this seems pretty bad. I hand't noticed this in their changelogs. Would someone experiencing the issue want to make a PR? I'll be fast about merging

[AndrewLeedham]

@hipstersmoothie looks like this is no longer relevant, it was added as a global option in [email protected]: lerna/lerna@7.0.1...7.0.2#diff-2032af9ea850f246d979f39fcde239aca6152ebc457758177256ac028123baefR92-R95

Seems redundant to retrospectively fix it, given Auto jumped from 3 - 7.x.

[hipstersmoothie]

Awesome!

[jackw]

I've just hit this issue whilst trying to debug why our repo started creating odd changelogs and unintentionally published a major version. We're running [email protected] and [email protected].

Unfortunately the global --registry argument was later removed in this PR which according to the commit in main was released in v7.2.0.

@hipstersmoothie I've opened a PR here that removes the flag from all version commands that are wrapped in dry-run checks.