Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilink card: support light blue bg and review spacing #1295

Open
inesdgomes opened this issue Jan 9, 2025 · 4 comments
Open

Multilink card: support light blue bg and review spacing #1295

inesdgomes opened this issue Jan 9, 2025 · 4 comments
Assignees
Labels

Comments

@inesdgomes
Copy link
Collaborator

@beatrizmartinmartins As requested by Davide, could we make some tweaks to the multilink card so it supports a light blue background? Please also review his comment about the spacing: https://www.figma.com/design/ulu2zb7ZOuT4VXu4M7Yp98?node-id=339-26900#1047735167

@beatrizmartinmartins
Copy link
Collaborator

@inesdgomes could you take a look at the new Data Card variant? I did create a new variant on the data card as it seems like the best fit. The MultiLink card is only used when we have links, and this is not the case.

@inesdgomes
Copy link
Collaborator Author

Hi @beatrizmartinmartins I think the data card does not work because we need a prominent heading. See here: https://www.figma.com/design/ulu2zb7ZOuT4VXu4M7Yp98?node-id=339-26900#1047735167

Also, the logic of the data card is already quite complex because of the two columns factor. We'd prefer not to add more variants. Could we try with the multilink card?

@beatrizmartinmartins
Copy link
Collaborator

@inesdgomes the multilink card doesn't allow for a light blue background that's why I decided to opt and use the Data Card. I used the same basis has this option right here, which from my understanding, we could just reuse it to build this new one right?

@inesdgomes
Copy link
Collaborator Author

@beatrizmartinmartins Don't think I understand. The new variant in the data card that you created does not have a heading, which is something that is needed for this use case: https://www.figma.com/design/ulu2zb7ZOuT4VXu4M7Yp98/ILO-Live?node-id=339-26900&t=foTA4qTB7hvezxqQ-0#1047735167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants