Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review proposed new card component #1293

Open
inesdgomes opened this issue Jan 7, 2025 · 3 comments
Open

Review proposed new card component #1293

inesdgomes opened this issue Jan 7, 2025 · 3 comments
Assignees
Labels

Comments

@inesdgomes
Copy link
Collaborator

The existing cards do not meet all the needs for ILO Live so Davide suggested creating a new component. @beatrizmartinmartins Could you please review and check that it makes sense to create a new component rather than adapting the ones we have?https://www.figma.com/design/ulu2zb7ZOuT4VXu4M7Yp98?node-id=339-26900#1047734755

@beatrizmartinmartins
Copy link
Collaborator

@inesdgomes could you check the event card new component?

I did made some changes mainly:

  • I decided to use the secondary button as it stands out a little bit more and it's used accordingly on other components, so it's best to use the same one.
  • The eyebrow I kept it above the heading as we use it everywhere like that.
  • Did had a new status tag as I think the one we have works perfectly.

@inesdgomes
Copy link
Collaborator Author

Thanks @beatrizmartinmartins. It looks good to me. Let me double check with Davide and Justin.

@inesdgomes
Copy link
Collaborator Author

@justintemps If you and Davide and are happy with this, it can move to development. event card new component

I can't tag Davide here in Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants