-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create section's variants and apply them to templates #1256
Comments
@inesdgomes you can check the new component with the specifications above detailed on this link Also, I made the changes on these templates: I think it works on them. What do you think? Maybe we need some sections without left and right paddings though |
|
|
Hi @beatrizmartinmartins Thanks, I finally reviewed this, really sorry for the delay. Here are some comments/questions:
|
Hey @inesdgomes , let's make a new proposal: Let's follow the typography spacing guidelines that we carefully set up a while ago and introduce that everywhere. I'd say let's not have a spacing for cards and another one for the rest, let's just make everything after a heading be 24px. I created the component for Section following these last guidelines. I think this is the best option to keep everything consistent and easier to scale. If we don't agree with this option, we can always separate the section in two variants: 24px and cards variant or something like that, but I honestly feel like this can lead to much more questions in the future rather than an improvement on the component and DS. Also, I will create some guidelines around it on when, where and how to use it so we can have a much deeper understanding of how this component behaves. Let me know what you think about this option. |
@inesdgomes Made the changes on the component and also on the templates |
Hi @beatrizmartinmartins Ok, that would make more sense and it would definitely be easier to implement indeed. I must say I find the space between headings and cards a bit too tight now, but I guess that's only because I'm very used to the spacing we had before. I think we can proceed with what you proposed. |
To be validated by Justin |
Define variants for the section component that have different spacing above, below and within. Check if it works in 2/3 different templates with different components.
The text was updated successfully, but these errors were encountered: