Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tag component so it supports different states #1205

Open
inesdgomes opened this issue Sep 12, 2024 · 11 comments
Open

Change tag component so it supports different states #1205

inesdgomes opened this issue Sep 12, 2024 · 11 comments
Assignees
Labels

Comments

@inesdgomes
Copy link
Collaborator

Hi @beatrizmartinmartins We need the tag component to be a bit more versatile. The use case is: we need to use the tag to show an event status. For example, the event can be: a) scheduled; b) starting in X min; c) live; d) interrupted; e) ended.

Please see here a design test that Davide, who's implementing the design system on ILO Live, did: https://www.figma.com/design/ulu2zb7ZOuT4VXu4M7Yp98/ILO-Live?node-id=65-3247&node-type=section&t=VcjLOH4WlNhcaEO2-0

Could you please:

  • Review the proposal
  • Make any improvements
  • Integrate the changes in the component using more agnostic labels for the different colours/states

Both Justin and I are happy with the proposal, we just think the 'Starting' status should be emphatic. Perhaps purple?

@inesdgomes inesdgomes changed the title Change tag component so it supports different colours Change tag component so it supports different states Sep 12, 2024
@beatrizmartinmartins
Copy link
Collaborator

Honestly, I'd rather create another component called Status Tag, because the Tag one is clicable and navigationable while this status one is not, and can not be deleted or anything like that. Wouldn't it be better to have them separate so we are able to use the Hover, Focus, etc states for the Tag, while on the Status one, we just need the states for Live, Schedule, etc? @inesdgomes @justintemps I did made a version of them here, but since they can't be removed, we are lacking some variants there that look weird.

@inesdgomes
Copy link
Collaborator Author

@beatrizmartinmartins Thanks - yes, let's create a new component, please.

@beatrizmartinmartins
Copy link
Collaborator

done. please check here @inesdgomes

@inesdgomes
Copy link
Collaborator Author

Thanks @beatrizmartinmartins. @justintemps Beatriz created a new component for the status that can be used in ILO Live. She suggested we do this, instead of trying to adapt the tag component, because the tag component is clickable and requires different status (active, hover, focus, reset), whereas we only need the status to be informative. Please check here and let us know if this can be moved to development.

@justintemps
Copy link
Member

Hey @inesdgomes and @beatrizmartinmartins this is fine design-wise, but how should we refer to these different states? It doesn't seem like we should call them by colors...

@inesdgomes
Copy link
Collaborator Author

inesdgomes commented Jan 2, 2025

Hi @beatrizmartinmartins See Justin's comment above. Do you agree with these labels? And if so, could you please update the designs?
Light green --> Active
Light blue --> Info
Red --> Alert
Light red --> Subtle Alert
Grey --> Inactive

@inesdgomes inesdgomes removed their assignment Jan 2, 2025
@beatrizmartinmartins
Copy link
Collaborator

@inesdgomes change done on the component properties. Check here

@inesdgomes
Copy link
Collaborator Author

Thanks! @justintemps Labels are added.

@inesdgomes
Copy link
Collaborator Author

@beatrizmartinmartins Before this moves to development, could you look at these comments from Davide? https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf?node-id=4579-8211#1085725366

@inesdgomes
Copy link
Collaborator Author

@beatrizmartinmartins Davide suggested that we have a small version of the tags. As discussed, please check if it's needed.

@inesdgomes
Copy link
Collaborator Author

@beatrizmartinmartins Apologies, I just saw your comment about the tag size in the new event card. Will get back to you on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants