-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve language toggle #1033
Comments
Made the changes you asked for here |
Thanks @beatrizmartinmartins The changes you made look good.
|
@inesdgomes Made that change on the designs. You can check it on the component. On the templates is not shown. |
Great, thanks @beatrizmartinmartins. @justintemps Here are the changes that were done to 'languagelabel' and 'mainlink' in the desktop navigation:
Changes can be seen in the component library: https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf/ILO-Components-Library?m=auto&node-id=6198-11143&t=BcrzzTsjGNg4AHmh-1 |
@justintemps Basically we added a line of 16px between the menu items so it looked different and users understood the difference between one and another. This line basically separates the language from the link. CC @inesdgomes |
@justintemps This can move to development. Repeating this comment so it's clear what are the changes that were done to 'languagelabel' and 'mainlink' in the desktop navigation:
Changes can be seen in the component library: https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf/ILO-Components-Library?m=auto&node-id=6198-11143&t=BcrzzTsjGNg4AHmh-1 |
@Shashika6 Here's a link to the component. See @inesdgomes's instructions above. When you make the PR, please ask her to review it. |
This is a sub-ticket of #823 & #1302
Hi @beatrizmartinmartins We've been receiving feedback saying that the language toggle is not visible or easy enough to use. A few things I think we could improve:
https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf/ILO-Components-Library?node-id=1433-3563&t=f7Y3EMocyjiNUGro-0
The text was updated successfully, but these errors were encountered: