Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysterious error on collation attempt #44

Open
tla opened this issue Sep 8, 2017 · 6 comments
Open

Mysterious error on collation attempt #44

tla opened this issue Sep 8, 2017 · 6 comments
Labels

Comments

@tla
Copy link
Member

tla commented Sep 8, 2017

Hi - I have run into an error when trying to collate the attached JSON input, which doesn't give much idea of the problem. If I remove the first witness (Bz449) then it works, but I can't see anything obviously wrong in the Bz449 input. Any hints would be very welcome.

Taras-iMac:collatex tla$ collatex -t --format json milestone-455.json > /dev/null
Unexpected error
null
Taras-iMac:collatex tla$

milestone-455.json.gz

@tla tla added the java label Sep 8, 2017
@tla
Copy link
Member Author

tla commented Sep 8, 2017

(p.s. collatex is a local wrapper that sets JAVA_HOME and executes the JAR file.)

@rhdekker
Copy link
Member

Hi,

Tried this on the latest code in the master branch and I can replicate the error. It gives me a little bit more information.

java -jar collatex-tools-1.8-SNAPSHOT.jar -t --format json ~/Downloads/milestone-455.json
Unexpected error
null
java.lang.NullPointerException
at eu.interedition.collatex.dekker.DekkerAlgorithm.collate(DekkerAlgorithm.java:187)
at eu.interedition.collatex.tools.CollationPipe.start(CollationPipe.java:153)
at eu.interedition.collatex.tools.CollateX.main(CollateX.java:45)

I am not yet sure what actually causes the error but at least this brings us a step further.

@rhdekker
Copy link
Member

rhdekker commented Sep 11, 2017

Hi,

I tried to collate the input data with the latest experimental version of the collation algorithm in a development branch and it returns without error. I included the output as an attachment to this message. Can you take a look at it and give feedback what you think of the quality of the alignment?

output_tara.json.zip

Best,
Ronald

@tla
Copy link
Member Author

tla commented Jan 30, 2018

Finally she replies...! Insofar as the input isn't regularised, I think the alignment is fine. Thanks, belatedly, for looking into this!

@tla
Copy link
Member Author

tla commented Feb 15, 2018

A follow-up question: which development branch has the working version, and how might I build it?

@rhdekker
Copy link
Member

rhdekker commented Feb 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants