Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenBSD like FreeBSD uses stdlib.h not malloc.h #65

Open
jturner opened this issue Sep 20, 2022 · 1 comment
Open

OpenBSD like FreeBSD uses stdlib.h not malloc.h #65

jturner opened this issue Sep 20, 2022 · 1 comment

Comments

@jturner
Copy link
Contributor

jturner commented Sep 20, 2022

Trying to build wasmtime on OpenBSD noticed it's trying to pull in malloc.h. It should be using stdlib.h like FreeBSD. Unless you get to it first, I'll submit a MR shortly. Thanks
@jturner jturner mentioned this issue Sep 20, 2022
Merged
@seanm
Copy link

seanm commented Jul 10, 2023

malloc.h is non-standard and obsolete, even on linux. It is required for some old functions like memalign but after looking over jitprofiling.c I don't see why it is needed, even on linux.

I think it can just be removed.

@seanm seanm mentioned this issue Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanm @jturner