Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please explain why you need to run anything as root #16

Open
SvenDowideit opened this issue Nov 29, 2021 · 4 comments
Open

Please explain why you need to run anything as root #16

SvenDowideit opened this issue Nov 29, 2021 · 4 comments

Comments

@SvenDowideit
Copy link

Don't run build scripts as root on the host. :)

@SvenDowideit SvenDowideit changed the title Please explain why you need to run aything as root Please explain why you need to run anything as root Nov 29, 2021
@SvenDowideit
Copy link
Author

SvenDowideit commented Nov 29, 2021

  1. in build/buildUOS.sh a dind container is made with a bind mount to /tmp/builder/ to give the script access to the dind docker socket. (no indication on the build.sh output that its hung - see the output of builder.log
  2. and then that code crashes, trying to clean up the /tmp/builder/ dir.

Is there a reason for the ESP build process to hide what it downloaded and built in this step?

@dvintel
Copy link
Contributor

dvintel commented Dec 3, 2021

Hi @SvenDowideit! There is nothing to hide, all the scripts are available to peruse and inspect. The folder is deleted since the contents are no longer needed.

If you have a suggestion of how we can make the build process better, we welcome pull/merge requests!

@brod-intel
Copy link
Contributor

Don't run build scripts as root on the host. :)

Why not?

@brod-intel
Copy link
Contributor

  1. in build/buildUOS.sh a dind container is made with a bind mount to /tmp/builder/ to give the script access to the dind docker socket. (no indication on the build.sh output that its hung - see the output of builder.log
  2. and then that code crashes, trying to clean up the /tmp/builder/ dir.

Is there a reason for the ESP build process to hide what it downloaded and built in this step?

Because this allows to do everything in a container. We only need Docker installed the host. That's it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants