Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wont work with non-public urls #13

Open
Casyfill opened this issue Oct 30, 2019 · 3 comments
Open

Wont work with non-public urls #13

Casyfill opened this issue Oct 30, 2019 · 3 comments

Comments

@Casyfill
Copy link

It seems that, on the contrast to intake itself, this plugin does not allow pulling data from the hon-public s3 buckets (for example), given that it uses naive geopandas.read_file, right?

As a solution, if would be probably nice to use provided fs object from intake, right?
Will be happy to PR

@ian-r-rose
Copy link
Collaborator

I regularly use this to read from private s3 buckets, though it presumes that you have your AWS credentials set up in your environment (either via env variables or a ~/.aws directory).

It does indeed use geopandas.read_file, which in turn uses fiona, which in turn uses ogr, which supports reading from s3. Since this is fundamentally different from the fs approach, I think there might be a challenge making it work for an arbitrary fsspec implementation, though I'd be happy to be proven wrong.

Are you proposing an alternate route besides using geopandas.read_file?

@Casyfill
Copy link
Author

Casyfill commented Oct 30, 2019

Indeed, just went down this rabbit hole to all the way to ogr.
The problem for me is that we use role assumptions, so static credentials won't work for me.

I will try exposing credentials before pulling, thanks!

@ian-r-rose
Copy link
Collaborator

If there are things that OGR can't handle, we might provide an fsspec aware code path here that downloads a temporary file and then loads that locally. I'm not very familiar with using role assumptions, so I don't know if there is a way to do this at present (here are the relevant docs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants