Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement revision last before in SpikeSortingLoader and SessionLoader #812

Open
2 tasks
k1o0 opened this issue Jul 20, 2024 · 1 comment
Open
2 tasks
Assignees

Comments

@k1o0
Copy link
Contributor

k1o0 commented Jul 20, 2024

In order to keep analysis results consistent the BWM code should load data via ONE using the revision argument which finds the last revision before a given date. Currently the SpikeSortingLoader only allows the loading of exact revisions. Here's the suggested solution:

  • Add argument to load_spike_sorting method to allow loading last revision before a given date
  • Optionally rename the current 'revision' parameter to 'exact_revision' to prevent confusion with behaviour of 'revision' param in ONE load methods

[Edit] I think this is implemented by using enfore_version: spike_loader.load_spike_sorting(revision=MODIFIED_BEFORE, enforce_version=False)

The SessionLoader currently has no way to pass in a revision.

@k1o0 k1o0 changed the title Implement revision last before in SpikeSortingLoader Implement revision last before in SpikeSortingLoader and SessionLoader Jul 20, 2024
k1o0 added a commit that referenced this issue Jul 20, 2024
@bimac
Copy link
Contributor

bimac commented Jul 29, 2024

for now: leave spike sorting as it is, add revision

@bimac bimac assigned bimac and k1o0 and unassigned bimac Jul 29, 2024
@k1o0 k1o0 assigned oliche and unassigned k1o0 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants