From 8845d5e7b1e64e96f6c6853cef6bf1c175183ddf Mon Sep 17 00:00:00 2001
From: "Chang, Hui-Tang" <huitang.chang@instill.tech>
Date: Wed, 15 May 2024 11:21:29 +0800
Subject: [PATCH] feat(vdp): support sorting pipelines under a namespace (#334)

Because

- We should support sorting pipelines under a namespace as well.

This commit

- Supports sorting pipelines under a namespace

---------

Co-authored-by: droplet-bot <droplet-bot@users.noreply.github.com>
---
 openapiv2/vdp/service.swagger.yaml | 18 +++++++++++++++++-
 vdp/pipeline/v1beta/pipeline.proto |  9 ++++++++-
 2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/openapiv2/vdp/service.swagger.yaml b/openapiv2/vdp/service.swagger.yaml
index 32d2aee9..5078abb0 100644
--- a/openapiv2/vdp/service.swagger.yaml
+++ b/openapiv2/vdp/service.swagger.yaml
@@ -100,7 +100,9 @@ paths:
             - VISIBILITY_PRIVATE
             - VISIBILITY_PUBLIC
         - name: order_by
-          description: Order by field.
+          description: |-
+            Order by field, with options for ordering by `id` or `create_time`.
+            Format: `order_by=id ASC` or `order_by=create_time DESC`.
           in: query
           required: false
           type: string
@@ -732,6 +734,13 @@ paths:
           in: query
           required: false
           type: boolean
+        - name: order_by
+          description: |-
+            Order by field, with options for ordering by `id` or `create_time`.
+            Format: `order_by=id ASC` or `order_by=create_time DESC`.
+          in: query
+          required: false
+          type: string
       tags:
         - Release
     post:
@@ -1187,6 +1196,13 @@ paths:
           enum:
             - VISIBILITY_PRIVATE
             - VISIBILITY_PUBLIC
+        - name: order_by
+          description: |-
+            Order by field, with options for ordering by `id` or `create_time`.
+            Format: `order_by=id ASC` or `order_by=create_time DESC`.
+          in: query
+          required: false
+          type: string
       tags:
         - Pipeline
     post:
diff --git a/vdp/pipeline/v1beta/pipeline.proto b/vdp/pipeline/v1beta/pipeline.proto
index 57de2a8c..70cbdbc2 100644
--- a/vdp/pipeline/v1beta/pipeline.proto
+++ b/vdp/pipeline/v1beta/pipeline.proto
@@ -407,7 +407,8 @@ message ListPipelinesRequest {
   optional bool show_deleted = 5 [(google.api.field_behavior) = OPTIONAL];
   // Limit results to pipelines with the specified visibility.
   optional Pipeline.Visibility visibility = 6 [(google.api.field_behavior) = OPTIONAL];
-  // Order by field.
+  // Order by field, with options for ordering by `id` or `create_time`.
+  // Format: `order_by=id ASC` or `order_by=create_time DESC`.
   optional string order_by = 7 [(google.api.field_behavior) = OPTIONAL];
 }
 
@@ -732,6 +733,9 @@ message ListUserPipelineReleasesRequest {
   ];
   // Include soft-deleted pipelines in the result.
   optional bool show_deleted = 6 [(google.api.field_behavior) = OPTIONAL];
+  // Order by field, with options for ordering by `id` or `create_time`.
+  // Format: `order_by=id ASC` or `order_by=create_time DESC`.
+  optional string order_by = 7 [(google.api.field_behavior) = OPTIONAL];
 }
 
 // ListUserPipelineReleasesResponse contains a list of pipeline releases.
@@ -955,6 +959,9 @@ message ListOrganizationPipelinesRequest {
   optional bool show_deleted = 6 [(google.api.field_behavior) = OPTIONAL];
   // Limit results to pipelines with the specified visibility.
   optional Pipeline.Visibility visibility = 7 [(google.api.field_behavior) = OPTIONAL];
+  // Order by field, with options for ordering by `id` or `create_time`.
+  // Format: `order_by=id ASC` or `order_by=create_time DESC`.
+  optional string order_by = 8 [(google.api.field_behavior) = OPTIONAL];
 }
 
 // ListOrganizationPipelinesResponse contains a list of pipelines.