Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct SERREAS derivation in ael03 #284

Merged
merged 12 commits into from
Dec 2, 2024
Merged

Correct SERREAS derivation in ael03 #284

merged 12 commits into from
Dec 2, 2024

Conversation

Melkiades
Copy link
Contributor

Fixes #269

@Melkiades Melkiades added the sme label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Unit Tests Summary

340 tests   252 ✅  1m 1s ⏱️
135 suites   88 💤
  1 files      0 ❌

Results for commit 0fab9b9.

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu requested a review from khatril November 12, 2024 15:02
@shajoezhu shajoezhu assigned BFalquet and khatril and unassigned BFalquet Nov 18, 2024
@Melkiades @pawelru
Update book/listings/adverse-events/ael03.qmd
db3c2f4 
Co-authored-by: Pawel Rucki <[email protected]>
Signed-off-by: Davide Garolini <[email protected]>
edelarua
edelarua previously requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small suggestions, and can you please update the snapshot as well? Then it should be good to go!

book/listings/adverse-events/ael03.qmd Outdated Show resolved Hide resolved
book/listings/adverse-events/ael03.qmd Outdated Show resolved Hide resolved
book/listings/adverse-events/ael03.qmd Outdated Show resolved Hide resolved
@shajoezhu
Copy link
Contributor

hi @Melkiades , can you update the snapshot please. Thank you!

@shajoezhu
Copy link
Contributor

hey @Melkiades , can you take a look at this again? the topleft is now different?

@Melkiades
Copy link
Contributor Author

Melkiades commented Nov 27, 2024 •
edited
Loading

hey @Melkiades , can you take a look at this again? the topleft is now different?

Fix coming!!

@Melkiades Melkiades mentioned this pull request Nov 27, 2024
Closed
@shajoezhu shajoezhu requested a review from pawelru November 28, 2024 15:32
@Melkiades Melkiades enabled auto-merge (squash) December 2, 2024 15:17
@Melkiades Melkiades merged commit a69de29 into main Dec 2, 2024
19 checks passed
@Melkiades Melkiades deleted the 269_correct_SERREAS_derivation@main branch December 2, 2024 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pawelru pawelru pawelru approved these changes

@edelarua edelarua edelarua left review comments

@khatril khatril Awaiting requested review from khatril

Assignees

@khatril khatril

Labels
Request changes sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SERREAS derivation in AEL03 needs correction
6 participants
@Melkiades @shajoezhu @pawelru @edelarua @BFalquet @khatril