Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlg-catalog switch from staged-dependencies to setup-r-dependencies for deps install #277

Closed
Tracked by #65
shajoezhu opened this issue Oct 25, 2024 · 2 comments
Closed
Tracked by #65
Assignees
Labels

Comments

@shajoezhu
Copy link
Contributor

shajoezhu commented Oct 25, 2024

TODO:

  1. edit .github/worflows/check.yaml
    1.1 adding line deps-installation-method: setup-r-dependencies under with: below these jobs,

    • roxygen
    • coverage
    • r-cmd-non-cran
    • r-cmd

    1.2 below deps-installation-method: setup-r-dependencies add its option if applicable (i.e. staged_dependencies.yaml has upstream entriex), e.g. for tern, it has upsteam rtables, formatters, and nestcolor

        insightsengineering/nestcolor
        insightsengineering/rtables
        insightsengineering/formatters

make sure lookup-refs has the same indentation as deps-installation-method

  1. rm staged_dependencies.yaml

see this PR for example https://github.com/insightsengineering/formatters/pull/325/files

@shajoezhu shajoezhu added the sme label Oct 25, 2024
@shajoezhu shajoezhu transferred this issue from insightsengineering/nestdevs-tasks Oct 25, 2024
@shajoezhu shajoezhu changed the title tlg-catalog tlg-catalog switch from staged-dependencies to setup-r-dependencies for deps install Oct 29, 2024
@shajoezhu
Copy link
Contributor Author

see #279

@pawelru
Copy link
Contributor

pawelru commented Nov 8, 2024

completed via #279

@pawelru pawelru closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants