Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update graph test snapshots to process as ggplot objects #182

Closed
edelarua opened this issue Dec 14, 2023 · 0 comments · Fixed by #183
Closed

Update graph test snapshots to process as ggplot objects #182

edelarua opened this issue Dec 14, 2023 · 0 comments · Fixed by #183
Assignees
@edelarua
Labels
enhancement New feature or request sme

Comments

@edelarua
Copy link
Contributor

Save graph snapshots as ggplot objects for better versatility and to allow setting of plot width/height parameters. Save snapshots for tables included in graph templates.

Add missing snapshots for fstg01 and fstg02.

Merge after insightsengineering/tern#1158
@edelarua edelarua added enhancement New feature or request sme labels Dec 14, 2023
@edelarua edelarua self-assigned this Dec 14, 2023
@edelarua edelarua mentioned this issue Dec 14, 2023
Merged
Melkiades pushed a commit that referenced this issue Dec 20, 2023
@edelarua @github-actions
Update graph snapshot processing (#183)
fa118d9 
Closes #182 

Merge after insightsengineering/tern#1158

This should standardize the generation of graph snapshots across
different systems and hopefully fix the failing integration tests for
graph snapshot differences.

Note: kmg01 snapshots will be fixed after `g_km` is refactored.

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edelarua edelarua

Labels
enhancement New feature or request sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update graph snapshot processing insightsengineering/tlg-catalog
1 participant
@edelarua