feat: added "fraction" statistic to the "analyze_var_count" method group #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All contributors have signed the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
|
@kpagacz please add NEWS entry and fix the tests. Please ignore CLA bot for a while - it's a known issue. @insightsengineering/nest-sme please kindly help with the review of this |
kpagacz
commented
Sep 17, 2024
Signed-off-by: Konrad Pagacz <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I wanted to display the count statistic in roughly this format:
xx / xx (xx.xx%), but it's impossible to useanalyze_varsin this manner. I could implement my ownanalyze_varsand the associated functions, but I only need this slight change in the code, and copying the whole thing seems like an overkill.Let me know if there's a more straightforward solution to display these statistics using the existing API (and not lose the S3 dispatch on different types of input variables).
@shajoezhu @pawelru @gogonzo If you can point me to the correct person to approach regarding this, I'd be grateful.