Refactoring of analyze_vars with specifics for .stat_names
#1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Melkiades
commented
Dec 12, 2024
Melkiades
commented
Dec 12, 2024
| all obs | ||
| ————————————————————— | ||
| n 4 | ||
| Mean (SD) 2.5 (1.3) |
Melkiades
commented
Dec 12, 2024
| n 5 | ||
| a 2 (40%) | ||
| b 1 (20%) | ||
| NA 2 (40%) |
Melkiades
commented
Dec 12, 2024
| 8 mean_ci (4.57, 5.69) 0 Mean 95% CI | ||
| 9 mean_sei (4.89, 5.38) 0 Mean -/+ 1xSE | ||
| 10 mean_sdi (4.35, 5.91) 0 Mean -/+ 1xSD | ||
| 2 sum 48.7 0 Sum |
There was a problem hiding this comment.
Why this calc changed?
Melkiades
commented
Dec 12, 2024
| .var, | ||
| ...) { | ||
| checkmate::assert_flag(na.rm) | ||
| s_summary <- function(x, denom, control, ...) { |
There was a problem hiding this comment.
still to test correctly: denom and control handling
Melkiades
commented
Dec 12, 2024
Melkiades
commented
Dec 16, 2024
Melkiades
commented
Dec 19, 2024
| out <- levels_per_stats | ||
| for (stat_i in seq_along(levels_per_stats)) { | ||
| common_stat_names <- intersect(names(levels_per_stats), names(labels_in)) | ||
| nm_of_levs <- levels_per_stats[[stat_i]] |
There was a problem hiding this comment.
to comment better
Melkiades
commented
Dec 19, 2024
| #' | ||
| #' @return A `list` with modified elements `x`, `.formats`, `.labels`, and `.indent_mods`. | ||
| #' @return A `list` with modified elements `stat_out`, `.formats`, `.labels`, `.levels`, and `.indent_mods`. |
There was a problem hiding this comment.
to fix: ungroup_stats should be removed in favor of get_*_from_stats
Melkiades
commented
Dec 19, 2024
Comment on lines
+296
to
-303
| empty_pval <- "pval" %in% names(stat_out) && length(stat_out[["pval"]]) == 0 | ||
| empty_pval_counts <- "pval_counts" %in% names(stat_out) && length(stat_out[["pval_counts"]]) == 0 | ||
| stat_out <- unlist(stat_out, recursive = FALSE) | ||
|
|
||
| # If p-value is empty it is removed by unlist and needs to be re-added | ||
| if (empty_pval) x[["pval"]] <- character() | ||
| if (empty_pval_counts) x[["pval_counts"]] <- character() |
There was a problem hiding this comment.
these are if pval is NULL?
Melkiades
commented
Dec 19, 2024
| n 5 | ||
| FALSE 1 (20%) | ||
| TRUE 2 (40%) | ||
| NA 2 (40%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes #1352