Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor summarize_change function, #1345

Closed
shajoezhu opened this issue Nov 1, 2024 · 1 comment · Fixed by #1347
Closed

refactor summarize_change function, #1345

shajoezhu opened this issue Nov 1, 2024 · 1 comment · Fixed by #1347
Assignees
Labels
bug Something isn't working priority sme

Comments

@shajoezhu
Copy link
Contributor

shajoezhu commented Nov 1, 2024

Rationale:

Issue was identified via updating the lbt03 template in scda.test using pharamverseadam data,

https://github.com/insightsengineering/scda.test/pull/153/files#diff-612b47e07d81651ea501f536e8b1e59b19e5018ba14f7cfe1efe13544df8620c

zero was reported, after some investigation, we found out in recent admiral, there was a change to set CHG to NA for baseline values, discussion was tracked in pharmaverse/admiral#2484

For lbt03 table, the summary statistics should be based on baseline AVAL values for baseline section, but for other visits in AVISIT, use CHG values, baseline values are flagged via baseline_flag: ABLFL

TODO:

  1. update summarize_change function
  2. update a_change_from_baseline function, better handle NA, can preprocess them to zeros
  3. adding test cases, allow CHG input to be NA
@Melkiades
Copy link
Contributor

The LBT03 template is the result of a junction between the analysis of AVAL at baseline and CHG at visit time. AVAL is summarized for baseline visits and and CHG is summarized for post-baseline visits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority sme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants