-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Rework <teal_module>$server
to get teal_data
object
#904
Comments
Acceptance Criteria:
We'll start with one module before hitting the rest. On deprecation topic, we have to think about users who created their own teal modules for their projects. How this update would affect these users and what we can do about it. |
https://github.com/insightsengineering/teal/blob/main/R/module_nested_tabs.R#L313 |
@chlebowa object passed to the modules should be wrapped in a reactive. To be specific then - modules should get reactive returning tdata. |
<teal_module>$server
to get tdata
object<teal_module>$server
to get teal_data
object
Closing in favour of #937 |
After insightsengineering/teal.data#161 modules should be refactored (all teal.modules.*) to receive
teal_data
object fromteal.data
.Dilemmas to solve:
tdata
class inteal
which is sent todata
argument inteal_module$server
? Should we soft-deprecate?data_merge
anddata_extract
module which is a candidate to refactor?The text was updated successfully, but these errors were encountered: