You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Modules should not depend on the class containing data and methods not needed in the modules.
Modules should receive named list of (reactive) data, then they can be reused outside of teal. Modules should have following arguments
tm_module(
a b c <instructions for choices>
data <list of reactives>,
expr <reactive expr>,
... # FilterPanel-api, metadata etc
)
Currently following methods from FilteredData are used in the modules:
$get_data(filtered = TRUE)
$get_data(filtered = FALSE) ❌ see occurrences. This can be fixed by including unfiltered data to the module also.
$datanames() - this will be the names of the list
$get_metadata(), $get_keys() - should we pass using ...? Please find the optimal solution.
$get_varlabels - this can be extracted from the raw data.frame object
Alternatively datasets can be wrapped in the simple class object with limited number of methods.
The text was updated successfully, but these errors were encountered:
Modules should not depend on the class containing data and methods not needed in the modules.
Modules should receive named list of (reactive) data, then they can be reused outside of teal. Modules should have following arguments
Currently following methods from FilteredData are used in the modules:
Alternatively datasets can be wrapped in the simple class object with limited number of methods.
The text was updated successfully, but these errors were encountered: