Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds srv_decorate_teal_data and ui_decorate_teal_data wrappers #1422

Conversation

averissimo
Copy link
Contributor

This reduces the code in the modules and avoids some of the strange req() of the original object

Makes it easier for modules developers to use our API.

-    decorated_output_q_no_print <- srv_transform_teal_data("decorate", data = output_q, transformators = decorators)
-    decorated_output_q <- reactive(within(decorated_output_q_no_print(), expr = print(plot)))
+   decorated_output_q <- srv_decorate_teal_data("decorate", data = output_q, transformators = decorators, expr = print(plot))
    plot_r <- reactive({
-      req(output_q())
+      req(decorated_output_q())
      decorated_output_q()
    })

@averissimo averissimo requested a review from m7pr November 22, 2024 13:41
@m7pr
Copy link
Contributor

m7pr commented Nov 22, 2024

nice

@averissimo
Copy link
Contributor Author

After stand-up, let's try this approach inside modules in {tmc} for now

@averissimo averissimo closed this Nov 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants