Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teal_transform_module vignette #1231

Closed
gogonzo opened this issue May 22, 2024 · 6 comments
Closed

teal_transform_module vignette #1231

gogonzo opened this issue May 22, 2024 · 6 comments
Labels

Comments

@gogonzo
Copy link
Contributor

gogonzo commented May 22, 2024

Vignette describing teal_transform_module, should contain:

  • what is teal_transform_module
  • how transform works in teal
  • how to create a module which uses transformers
  • showcase the app with some transformers

Please edit data-transform-as-shiny-module.Rmd file

@donyunardi
Copy link
Contributor

I believe @vedhav did this already with #1283
Can this be closed?

@vedhav
Copy link
Contributor

vedhav commented Aug 8, 2024

I think we can add a sample app in teal.gallery with the transform feature. I will do this today and we can close this.

@gogonzo
Copy link
Contributor Author

gogonzo commented Aug 8, 2024

@donyunardi existing vignette needs to be redacted. Vignette is missing "how to create a module which uses transforms". Plus, I'd remove a section "Custom placement of the transform UI" for now, I think we need to discuss the placement of the transform again.

@gogonzo
Copy link
Contributor Author

gogonzo commented Aug 8, 2024

I think we can add a sample app in teal.gallery with the transform feature. I will do this today and we can close this.

Good idea 👍

@donyunardi
Copy link
Contributor

I think we can add a sample app in teal.gallery with the transform feature. I will do this today and we can close this.

Shouldn't we make a new issue for this? Sounds like we're extending the scope of this issue which is only to create a vignette.

@vedhav
Copy link
Contributor

vedhav commented Aug 13, 2024

Yes, We can close this one. The custom-transform app is deployed and we can take the discussion about that app on the PR insightsengineering/teal.gallery#177

@vedhav vedhav closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants