Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve disk space consumption by bookmarks #1188

Open
Tracked by #1011
chlebowa opened this issue Mar 26, 2024 · 1 comment
Open
Tracked by #1011

Solve disk space consumption by bookmarks #1188

chlebowa opened this issue Mar 26, 2024 · 1 comment

Comments

@chlebowa
Copy link
Contributor

Companion to #1011

teal bookmarks are duped to files stored on the server (literature).

The state itself is negligibly small (a few kilobytes) but report cards can run into dozens of megabytes.

Find and implement solution. Note that blindly deleting existing bookmarks is possible but not functional as they may be in use.

@chlebowa
Copy link
Contributor Author

Minutes of discussion 28 March 2024

  1. The fact that report bookmarks are so large may be due not solely to the content but also additional code required to deserialize R6 objects. Perhaps isolating contents from report cards could decrease the size. This would perhaps require heavy intervention in teal.reporter.
  2. We should find out how much disk space is actually allotted to a deployed app.
  3. Tracking bookmark use is possible. onRestore(d) callbacks can save metadata to a file in the bookmark directory.
  4. Discussed ways of removing bookmarks:
    a) onBookmark, check when bookmarks were last accessed (file.info) and delete ones that haven't been used
    b) allow user to name the bookmark directory and have them directly communicate with app dev regarding keeping and removing bookmarks
    c) create module that reads list of bookmarks from disk and allows user to remove them; run this module only for specific users (session$user?)
    d) allow user to add expiration time when creating bookmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant