From 161e48056964623c2780c96b13b71c704dcadb1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20Ka=C5=82=C4=99dkowski?= Date: Fri, 22 Nov 2024 17:33:46 +0100 Subject: [PATCH] Resolve todos (#1410) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: m7pr Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com> Co-authored-by: Lluís Revilla --- R/module_data_summary.R | 6 ------ R/module_filter_manager.R | 1 - R/module_nested_tabs.R | 8 -------- R/module_snapshot_manager.R | 1 - R/module_teal.R | 1 - R/module_transform_data.R | 2 +- tests/testthat/test-rcode_utils.R | 11 ----------- 7 files changed, 1 insertion(+), 29 deletions(-) diff --git a/R/module_data_summary.R b/R/module_data_summary.R index 6fe96702b0..72e8a1850c 100644 --- a/R/module_data_summary.R +++ b/R/module_data_summary.R @@ -157,12 +157,6 @@ get_filter_overview_wrapper <- function(teal_data) { datanames, function(dataname) { parent <- teal.data::parent(joinkeys, dataname) - # todo: what should we display for a parent dataset? - # - Obs and Subjects - # - Obs only - # - Subjects only - # todo (for later): summary table should be displayed in a way that child datasets - # are indented under their parent dataset to form a tree structure subject_keys <- if (length(parent) > 0) { names(joinkeys[dataname, parent]) } else { diff --git a/R/module_filter_manager.R b/R/module_filter_manager.R index 99575dea6f..116839a3a0 100644 --- a/R/module_filter_manager.R +++ b/R/module_filter_manager.R @@ -388,4 +388,3 @@ methods::setOldClass("reactivevalues") } ) ) -# todo: prevent any teal_slices attribute except mapping diff --git a/R/module_nested_tabs.R b/R/module_nested_tabs.R index 82f525cc18..748ca63785 100644 --- a/R/module_nested_tabs.R +++ b/R/module_nested_tabs.R @@ -319,14 +319,6 @@ srv_teal_module.teal_module <- function(id, # When previewer is delayed, cards are bookmarked only if previewer has been initiated (visited). module_out(.call_teal_module(modules, datasets, module_teal_data, reporter)) } - - # todo: (feature request) add a ReporterCard to the reporter as an output from the teal_module - # how to determine if module returns a ReporterCard so that reportPreviewer is needed? - # Should we insertUI of the ReportPreviewer then? - # What about attr(module, "reportable") - similar to attr(module, "bookmarkable") - if ("report" %in% names(module_out)) { - # (reactively) add card to the reporter - } }) module_out diff --git a/R/module_snapshot_manager.R b/R/module_snapshot_manager.R index 676ffbd9ff..ebf345861f 100644 --- a/R/module_snapshot_manager.R +++ b/R/module_snapshot_manager.R @@ -283,7 +283,6 @@ srv_snapshot_manager <- function(id, slices_global) { s <- "Initial application state" ### Begin restore procedure. ### snapshot <- snapshot_history()[[s]] - # todo: as.teal_slices looses module-mapping if is not global snapshot_state <- as.teal_slices(snapshot) slices_global$slices_set(snapshot_state) removeModal() diff --git a/R/module_teal.R b/R/module_teal.R index 16d4ac280d..091d1b57d4 100644 --- a/R/module_teal.R +++ b/R/module_teal.R @@ -210,7 +210,6 @@ srv_teal <- function(id, data, modules, filter = teal_slices()) { data_load_status <- reactive({ if (inherits(data_pulled(), "teal_data")) { "ok" - # todo: should we hide warnings on top for a data? } else if (inherits(data, "teal_data_module")) { "teal_data_module failed" } else { diff --git a/R/module_transform_data.R b/R/module_transform_data.R index 1d3607b4f3..f47a13d051 100644 --- a/R/module_transform_data.R +++ b/R/module_transform_data.R @@ -27,7 +27,7 @@ ui_transform_data <- function(id, transformers = list(), class = "well") { function(name) { data_mod <- transformers[[name]] wrapper_id <- ns(sprintf("wrapper_%s", name)) - div( # todo: accordion? + div( # class .teal_validated changes the color of the boarder on error in ui_validate_reactive_teal_data # For details see tealValidate.js file. class = c(class, "teal_validated"), diff --git a/tests/testthat/test-rcode_utils.R b/tests/testthat/test-rcode_utils.R index 8983355517..0dcd33d216 100644 --- a/tests/testthat/test-rcode_utils.R +++ b/tests/testthat/test-rcode_utils.R @@ -47,14 +47,3 @@ testthat::test_that("get_rcode_libraries returns current session packages", { ) ) }) - -testthat::test_that("get_datasets_code returns code only for specified datanames", { - # todo: need to use code dependency? Or test it later via public functions/modules - datasets <- teal.slice::init_filtered_data( - list( - IRIS = iris, - MTCARS = mtcars - ) - ) - testthat::expect_true(TRUE) -})