Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

241 unify namespace names for type_download_ui #242

Closed
wants to merge 3 commits into from
Closed

241 unify namespace names for type_download_ui #242

wants to merge 3 commits into from

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Apr 24, 2024

fix #241

@m7pr m7pr added the core label Apr 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            82      82  0.00%    58-153
R/get_dt_rows.R                  13      13  0.00%    44-56
R/ggplot2_args.R                 49       0  100.00%
R/include_css_js.R                7       1  85.71%   17
R/nested_closeable_modal.R       16      16  0.00%    83-98
R/optionalInput.R               255     212  16.86%   149-447, 501, 554, 560, 575-588
R/panel_group.R                  90      90  0.00%    50-190
R/plot_with_settings.R          382      22  94.24%   295-308, 330, 367-368, 379-380, 654-655, 657, 659
R/standard_layout.R              35       0  100.00%
R/table_with_settings.R         173       1  99.42%   85
R/utils.R                        14       1  92.86%   7
R/verbatim_popup.R               99      49  50.51%   65-80, 106-107, 109, 117-145, 166
R/white_small_well.R              7       7  0.00%    19-25
TOTAL                          1245     494  60.32%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: dd19165

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited
Loading

Unit Tests Summary

  1 files   11 suites   1m 16s ⏱️
122 tests 113 ✅ 2 💤 2 ❌ 5 🔥
303 runs  294 ✅ 2 💤 2 ❌ 5 🔥

For more details on these failures and errors, see this check.

Results for commit dd19165.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024 •
edited
Loading

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
plot_with_settings_ui 💚 $38.65$ $-2.32$ $-20$ $-2$ $+2$ $+5$

Results for commit 733d9a4

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor Author

m7pr commented Jun 12, 2024

I have read the CLA Document and I hereby sign the CLA

@m7pr
Copy link
Contributor Author

m7pr commented Jun 12, 2024

recheck

@donyunardi
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@donyunardi
Copy link
Contributor

@gogonzo
Can we merge this? If so, please do.

@gogonzo
Copy link
Contributor

gogonzo commented Jun 26, 2024

It's not worth spending time on it. I'm closing this PR as the value added of the change is minimal and PR already took too much attention

@gogonzo gogonzo closed this Jun 26, 2024
@gogonzo gogonzo deleted the 241_dwnl@main branch June 26, 2024 16:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gogonzo gogonzo gogonzo approved these changes

Assignees

@gogonzo gogonzo

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent naming ID for type_download_ui for table_with_settings and plot_with_settings
3 participants
@m7pr @donyunardi @gogonzo