Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Dependencies Test - max #276

Closed
wants to merge 1 commit into from

Conversation

donyunardi
Copy link
Contributor

@donyunardi donyunardi commented Jan 3, 2025

Fixing the failed scheduled pipeline caused by not installing the latest formatters by adding the package to Config/Needs/verdepcheck:
https://github.com/insightsengineering/teal.widgets/actions/runs/12532246429/job/34950774578#step:9:424

@donyunardi donyunardi added the core label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            82      82  0.00%    58-153
R/get_dt_rows.R                  13      13  0.00%    44-56
R/ggplot2_args.R                 49       0  100.00%
R/include_css_js.R                7       1  85.71%   17
R/nested_closeable_modal.R       16      16  0.00%    83-98
R/optionalInput.R               255     212  16.86%   149-447, 501, 554, 560, 575-588
R/panel_group.R                  90      90  0.00%    50-190
R/plot_with_settings.R          383      23  93.99%   283-296, 318, 355-356, 367-368, 384, 654-655, 657, 659
R/standard_layout.R              35       0  100.00%
R/table_with_settings.R         173       1  99.42%   85
R/utils.R                        14       1  92.86%   7
R/verbatim_popup.R               99      49  50.51%   65-80, 106-107, 109, 117-145, 166
R/white_small_well.R              7       7  0.00%    19-25
TOTAL                          1246     495  60.27%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 599833d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Unit Tests Summary

  1 files   11 suites   1m 26s ⏱️
122 tests 112 ✅ 10 💤 0 ❌
326 runs  316 ✅ 10 💤 0 ❌

Results for commit 599833d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
plot_with_settings 💔 $2.81$ $+2.66$ $0$ $0$ $0$ $0$
plot_with_settings_ui 💔 $39.83$ $+1.18$ $0$ $0$ $0$ $0$
table_with_settings 💔 $2.31$ $+1.99$ $0$ $0$ $0$ $0$

Results for commit de93e9d

♻️ This comment has been updated with latest results.

@donyunardi donyunardi changed the title add formatters to config/needs/verdepcheck Fix failing Dependencies Test - max Jan 3, 2025
@donyunardi
Copy link
Contributor Author

Adding formatters in Config/Needs/Verdepcheck doesn't fix the failing pipeline because formatters is not listed as dependencies in Imports or Suggests:
https://github.com/insightsengineering/teal.widgets/actions/runs/12604728949/job/35132180697#step:9:276

I figure we don't want to add formatters to Imports or Suggests, which means we'll just wait until formatters is released.

Until then, this will keep on failing.

@donyunardi donyunardi closed this Jan 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
@averissimo
Copy link
Contributor

This kind of problem is addressed with this PR: insightsengineering/r-verdepcheck-action#22

In practice, it will add pharmaverse's r-universe or any other repository during verdepcheck.

I believe this is an acceptable compromise that is simple and that could be applied to max strategy

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants