From 8b1befe43488499a61bd970b435b4888a4679aea Mon Sep 17 00:00:00 2001 From: meldolan <148221803+meldolan@users.noreply.github.com> Date: Wed, 26 Jun 2024 15:39:37 +0100 Subject: [PATCH 1/2] Update custom-basic-table-arguments.Rmd (#1) (#247) --- vignettes/custom-basic-table-arguments.Rmd | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/vignettes/custom-basic-table-arguments.Rmd b/vignettes/custom-basic-table-arguments.Rmd index b13067b4..29f6d344 100644 --- a/vignettes/custom-basic-table-arguments.Rmd +++ b/vignettes/custom-basic-table-arguments.Rmd @@ -17,23 +17,23 @@ creator in the server function, which has the lowest priority. The implementation should consist of 5 steps: -1. Adding `basic_table_args` argument to the `tm_t_*` function and then its server function. +1. Add the `basic_table_args` arguments to the `tm_t_*` function and then its server function. The default should be set to the `basic_table_args()` function for a single plot. and `list(default = basic_table_args())` multi-table modules. -2. Adding a validation (e.g. `stopifnot` or `checkmate`) of the `basic_table_args` argument to the `tm_*` function. +2. Add validation (e.g. `stopifnot` or `checkmate`) for the `basic_table_args` arguments to the `tm_*` function. The validation is more complex for multi-table modules, where the `ggplot2_args` could be a `list`. The module creator has to provide a list of plots names, which should be validated at this step and added to the `param` field in `roxygen2`. For multi-table modules the step `if (is_basic_table_args) basic_table_args <- list(default = basic_table_args)` is recommended. -3. Aggregating and reducing all `basic_table_args` sources with `resolve_basic_table_args()`. -4. Usage of the `parse_basic_table_args()` function which will aggregate and reduce all inputs +3. Aggregate and reduce all `basic_table_args` sources with `resolve_basic_table_args()`. +4. Use the `parse_basic_table_args()` function which will aggregate and reduce all inputs to one expression. -5. Adding the created expression to the chunk with a table. +5. Add the created expression to the chunk with a table. The `parse_basic_table_args()` function picks the first non NULL value for each argument, checking in order: -1. `basic_table_args` argument provided by the end user. +1. `basic_table_args` arguments provided by the end user. For multi-table case, per table (`basic_table_args_table`) and then default (`basic_table_args_default`) setup. 2. Global R variable (`options`), `teal.basic_table_args`. 3. `basic_table_args_developer` which is a developer setup, lowest priority. From 285e85e369a46d0e6f3c90b055cc744dc24d9526 Mon Sep 17 00:00:00 2001 From: donyunardi Date: Wed, 26 Jun 2024 14:40:28 +0000 Subject: [PATCH 2/2] [skip actions] Bump version to 0.4.2.9013 --- DESCRIPTION | 4 ++-- NEWS.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 5c69d281..94ffc213 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Package: teal.widgets Title: 'shiny' Widgets for 'teal' Applications -Version: 0.4.2.9012 -Date: 2024-05-24 +Version: 0.4.2.9013 +Date: 2024-06-26 Authors@R: c( person("Dawid", "Kaledkowski", , "dawid.kaledkowski@roche.com", role = c("aut", "cre")), person("Pawel", "Rucki", , "pawel.rucki@roche.com", role = "aut"), diff --git a/NEWS.md b/NEWS.md index faee9c64..45e64636 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,4 +1,4 @@ -# teal.widgets 0.4.2.9012 +# teal.widgets 0.4.2.9013 # teal.widgets 0.4.2