Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Remove unneeded dependencies from {teal.transform} #194

Open
m7pr opened this issue Feb 13, 2024 · 4 comments
Open

[Feature Request]: Remove unneeded dependencies from {teal.transform} #194

m7pr opened this issue Feb 13, 2024 · 4 comments

Comments

@m7pr
Copy link
Contributor

m7pr commented Feb 13, 2024

There is a couple of R packages that could be removed from the package. Below is the list of few. Maybe at least a couple can be removed.

@m7pr
Copy link
Contributor Author

m7pr commented Feb 13, 2024

CC @donyunardi and @pawelru . Should we do this before or after the initial CRAN release? I think removal of those packages should take a day for the removal, and another one for testing the package. I have no idea how much time would take testing all other packages + deployed teal gallery apps after removal of few packages from the code base of {teal.transform}. Proposing this improvement as I know we are planning to have a thorough review of {teal.gallery} apps anyway.

@donyunardi
Copy link
Contributor

Hi @m7pr
Thanks for this. I'm all for removing unneeded dependencies.
Since this is not a blocker for our initial CRAN release, let's do this after.

@donyunardi donyunardi changed the title [Feature Request]: Remove unneeded dependencies from {teal.reporter} [Feature Request]: Remove unneeded dependencies from {teal.transform} Feb 13, 2024
@pawelru
Copy link
Contributor

pawelru commented Feb 13, 2024

I have spoken with @donyunardi and we agreed to take a minimalist approach to release "as is". These are all good discoveries and I really don't want to discourage you but my concern here is that such things will prolong the release cycle and there are teal.modules.xyz waiting on the list.

The other thing is that I do have some idea about a fundamental package refactor in which rlang, shiny and teal.code play key role. I don't mind the rest.

@m7pr
Copy link
Contributor Author

m7pr commented Feb 14, 2024

Thanks @pawelru and @donyunardi for the reply. I totally understand this is not critical and can extend the release period. Let's talk once we get back to the actual refactor, after all {teal.*} packages are on CRAN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants