Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_spec for numeric variables could be a range selection? #1

Open
nikolas-burkoff opened this issue Jan 19, 2022 · 2 comments
Open

Comments

@nikolas-burkoff
Copy link
Contributor

From insightsengineering/teal#436 (comment)

Not sure how useful current behaviour is:
image

If this is changed then we need to handle this case carefully:
image

@denisovan31415
Copy link
Contributor

If we are to implement this, then we would be under taking the step of making filter_spec having the capabilities of filter_panel?

That might not be a rabbit hole of redundancy.

@pawelru
Copy link
Contributor

pawelru commented Jan 20, 2022

Yes we are aware of it and it was like that since the very beginning. It seems that the assumption of always a choices type of data is too strong. I like the way filter-panel handles it via dispatch on types of data. I wanted to basically re-use that functionality into data-extract-spec but it's a big task.

@gogonzo gogonzo transferred this issue from insightsengineering/teal Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants