Refactor filter panel - summary and collapsible #55
Comments
|
The hiding/showing of the filter panel itself is, unfortunately, working as intended because we made the state of this particular UI feature global across all modules (disregarding whether they actually show it or not). I will investigate the disappearance of the summary. |
|
I can confirm the buggy behaviour is reproducible. Clicking on any input makes the Filter Overview show up again. I will dig deeper. |
|
There is something fishy about the active_datanames reactive. Basically what happens is that FilteredData$srv_filter_overview does not trigger in some scenarios. I do not know yet why. |
Merged
|
This looks to solve the problem #57 |
kpagacz
added a commit
that referenced
this issue
Jun 30, 2022
* Fixed a bug when the filter panel overview would not recalculate when changing a new module in cases when the panel was hidden during a transition between the modules. * Changed the behaviour of the burger button when there are no active datanames in the filter panel. Closes #55
kpagacz
added a commit
to insightsengineering/teal
that referenced
this issue
Jun 30, 2022
Polkas
changed the title
Polkas
pushed a commit
to insightsengineering/teal
that referenced
this issue
Jul 13, 2022
* hide/show the filter panel Related to insightsengineering/teal.slice#55 Co-authored-by: Dawid Kałędkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Refactor the FilterPanel regarding the linkage with teal.slice and the collapse functionality.
We want to make the process more elegant and clear. More than that there could be a hidden problem with reactivity when closing and opening the Filter Panel or with possible calls for filters from a module server function.
Take into account that #60 is already merged.
We solve the problem only for active filter , sb have to check the influence on the main part of the FilterPanel.
If the main Filter UI does not need
shiny::outputOptions(output, "table", suspendWhenHidden = FALSE)call too.The text was updated successfully, but these errors were encountered: