Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Improvements on logger::log_shiny_input_change #383

Closed
m7pr opened this issue May 16, 2024 · 1 comment
Closed

[Feature Request]: Improvements on logger::log_shiny_input_change #383

m7pr opened this issue May 16, 2024 · 1 comment
Labels
blocked core enhancement New feature or request

Comments

@m7pr
Copy link
Contributor

m7pr commented May 16, 2024 •
edited
Loading

Once this PR daroczig/logger#155 is merged and released, we can freely remove if (shiny::isRunning()) conditions included before logger::log_shiny_input_change (introduced in #382)
@m7pr m7pr added enhancement New feature or request blocked core labels May 16, 2024
@m7pr m7pr mentioned this issue May 16, 2024
Merged
@m7pr
Copy link
Contributor Author

m7pr commented Jun 20, 2024

No longer needed as we introduce our own log_shiny_input_changes insightsengineering/teal.logger#84

@m7pr m7pr closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m7pr