From 095e334f362efea03d3db7e0ef61f67525d67238 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Ver=C3=ADssimo?= <211358+averissimo@users.noreply.github.com> Date: Mon, 11 Sep 2023 14:30:58 +0200 Subject: [PATCH] fix: remove rlang call and add changes to NEWS --- NEWS.md | 4 ++++ R/adtteSpec.R | 2 +- R/assaySpec.R | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/NEWS.md b/NEWS.md index 5ddd7206..fa5ad69b 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,9 @@ # teal.modules.hermes 0.1.5.9002 +### Miscellaneous +* Added placeholders for `assaySpec`, `adtteSpec` and `geneSpec` inputs when no option is selected. +* Disabled the dropdown input for `assaySpec` and `adtteSpec` when there are no options available. + # teal.modules.hermes 0.1.5 ### Bug Fixes diff --git a/R/adtteSpec.R b/R/adtteSpec.R index 7a1f062d..5feca2a3 100644 --- a/R/adtteSpec.R +++ b/R/adtteSpec.R @@ -328,7 +328,7 @@ adtteSpecServer <- function(id, # nolint ) session$sendCustomMessage( "toggle_dropdown", - list(input_id = session$ns("paramcd"), disabled = rlang::is_empty(paramcd_choices)) + list(input_id = session$ns("paramcd"), disabled = (length(paramcd_choices) == 0)) ) }) diff --git a/R/assaySpec.R b/R/assaySpec.R index 8179e3ae..9c72ab7d 100644 --- a/R/assaySpec.R +++ b/R/assaySpec.R @@ -136,7 +136,7 @@ assaySpecServer <- function(id, # nolint updateSelectizeInput(session, "name", choices = choices) session$sendCustomMessage( "toggle_dropdown", - list(input_id = session$ns("name"), disabled = rlang::is_empty(choices)) + list(input_id = session$ns("name"), disabled = (length(choices) == 0)) ) })