You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix call to merge_expression_module, data_extract_multiple_srv and merge_expression_srv by removing join_keys argument. I adjusted teal.transform functions to work with new data (reactive teal_data). Adjusted methods doesn't need join_keys object as join_keys are already in teal_data object.
Fix merge call evaluation in the module. Object data inherits from qenv so we don't need to convert tdata -> qenv anymore. Beware, exact calls in your module might differ from the one below.
there might be more calls to data. Please beware that now data is a reactive holding teal_data instead of tdata (list of reactives).
example change in validation rules
iv$add_rule("variables", shinyvalidate::sv_in_set(
# set = names(data[[dataname]]()), message_fmt = "Not all selected variables exist in the data" # old
set = names(data()[[dataname]]), message_fmt = "Not all selected variables exist in the data" # new
))
Make PR to the @refactor branch with only one module changed. ONE PR, ONE MODULE. Include example app in the initial comment!
First package is refactored. Went pretty easy. There are some validate/req artifacts in some modules which appears for a fraction of seconds. We will take care of it later 💪
part of insightsengineering/teal#937
installation instructions:
Steps:
tm_module_of_your_choice@refactor
.merge_expression_module
,data_extract_multiple_srv
andmerge_expression_srv
by removingjoin_keys
argument. I adjustedteal.transform
functions to work with newdata
(reactive teal_data). Adjusted methods doesn't needjoin_keys
object asjoin_keys
are already inteal_data
object.data
inherits fromqenv
so we don't need to converttdata -> qenv
anymore. Beware, exact calls in your module might differ from the one below.data
. Please beware that now data is a reactive holdingteal_data
instead oftdata
(list of reactives).@refactor
branch with only one module changed. ONE PR, ONE MODULE. Include example app in the initial comment!Progress list:
tdata
toteal_data
-tm_a_pca
#608tdata
toteal_data
-tm_a_regression
#609tdata
toteal_data
-tm_front_page
#614tdata
toteal_data
-tm_g_bivariate
#605tdata
toteal_data
-tm_g_distribution
#606tdata
toteal_data
-tm_g_response
#607tdata
toteal_data
-tm_g_scatterplot
#610tdata
toteal_data
-tm_g_scatterplotmatrix
#611tdata
toteal_data
-tm_outliers
#612tdata
toteal_data
-tm_t_crosstable
#613The text was updated successfully, but these errors were encountered: