Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tm_outliers: Check validations #414

Open
mhallal1 opened this issue Jun 14, 2022 · 2 comments
Open

tm_outliers: Check validations #414

mhallal1 opened this issue Jun 14, 2022 · 2 comments
Labels
core good first issue Good for newcomers

Comments

@mhallal1
Copy link
Collaborator

mhallal1 commented Jun 14, 2022

In tm_outliers, when are those validations below used and employed?
Please check and remove if unnecessary:
Screenshot from 2022-06-14 11-19-40

@mhallal1 mhallal1 added the core label Jun 14, 2022
@nikolas-burkoff nikolas-burkoff added the good first issue Good for newcomers label Sep 22, 2022
@donyunardi
Copy link
Contributor

donyunardi commented Nov 10, 2022

Acceptance Criteria

  • Assess and remove unnecessary validation: line 322, 324, 330.
  • Provide context on how the validations (the one that's being kept) are being used.

@chlebowa
Copy link
Contributor

322 and 330 have been transferred to input validators.
324 remained and is used if the data provided warrants them. They don't kick in the example app because choices for categorical_var are specified like this:

ADSL <- synthetic_cdisc_data("latest")$adsl

fact_vars_adsl <- names(Filter(isTRUE, sapply(ADSL, is.factor)))
vars <- choices_selected(variable_choices(ADSL, fact_vars_adsl))

(...)

categorical_var = data_extract_spec(
  dataname = "ADSL",
  filter = filter_spec(
    vars = vars,
    choices = value_choices(ADSL, vars$selected),
    selected = value_choices(ADSL, vars$selected),
    multiple = TRUE
  )
),

but if the app developer has the power to pass invalid choices.

This is not a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants