From 77ad143e0f7991e229f0e5d84b52f9ce07441669 Mon Sep 17 00:00:00 2001 From: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com> Date: Tue, 16 Jan 2024 08:58:04 +0100 Subject: [PATCH] 507 reevaluate `variable_types` (#622) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit companion to https://github.com/insightsengineering/teal.slice/pull/508 --------- Signed-off-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com> Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> --- DESCRIPTION | 18 ++++++++---------- NEWS.md | 1 + R/tm_variable_browser.R | 2 +- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 23c8b048a..6f1d33a09 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -40,7 +40,6 @@ Imports: teal.code (>= 0.4.1.9009), teal.logger (>= 0.1.1), teal.reporter (>= 0.2.0), - teal.slice (>= 0.4.0.9028), teal.widgets (>= 0.4.0), tern (>= 0.7.10), tibble (>= 2.0.0), @@ -75,15 +74,14 @@ Config/Needs/verdepcheck: haleyjeppson/ggmosaic, tidyverse/ggplot2, daroczig/logger, tidyverse/magrittr, r-lib/scales, daattali/shinyjs, rstudio/shinyvalidate, dreamRs/shinyWidgets, tidyverse/stringr, insightsengineering/teal.code, insightsengineering/teal.logger, - insightsengineering/teal.reporter, insightsengineering/teal.slice, - insightsengineering/teal.transform, insightsengineering/teal.widgets, - insightsengineering/tern, tidyverse/tibble, tidyverse/tidyr, - r-lib/tidyselect, tidymodels/broom, daattali/colourpicker, - daattali/ggExtra, aphalo/ggpmisc, aphalo/ggpp, baddstats/goftest, - gridExtra, ramnathv/htmlwidgets, jeroen/jsonlite, yihui/knitr, - deepayan/lattice, MASS, insightsengineering/nestcolor, r-lib/rlang, - insightsengineering/rtables, sparkline, insightsengineering/teal.data, - r-lib/testthat + insightsengineering/teal.reporter, insightsengineering/teal.transform, + insightsengineering/teal.widgets, insightsengineering/tern, + tidyverse/tibble, tidyverse/tidyr, r-lib/tidyselect, tidymodels/broom, + daattali/colourpicker, daattali/ggExtra, aphalo/ggpmisc, aphalo/ggpp, + baddstats/goftest, gridExtra, ramnathv/htmlwidgets, jeroen/jsonlite, + yihui/knitr, deepayan/lattice, MASS, insightsengineering/nestcolor, + r-lib/rlang, insightsengineering/rtables, sparkline, + insightsengineering/teal.data, r-lib/testthat Config/Needs/website: insightsengineering/nesttemplate Encoding: UTF-8 Language: en-US diff --git a/NEWS.md b/NEWS.md index 0d3ee39a4..bf7f6f2f9 100644 --- a/NEWS.md +++ b/NEWS.md @@ -6,6 +6,7 @@ ### Miscellaneous +* Removed `teal.slice` dependencies. * Specified minimal version of package dependencies. # teal.modules.general 0.2.16 diff --git a/R/tm_variable_browser.R b/R/tm_variable_browser.R index 705a1b229..901d3ca18 100644 --- a/R/tm_variable_browser.R +++ b/R/tm_variable_browser.R @@ -1189,7 +1189,7 @@ render_tab_table <- function(dataset_name, parent_dataname, output, data, input, ) # get icons proper for the data types - icons <- stats::setNames(teal.slice:::variable_types(df), colnames(df)) + icons <- vapply(df, function(x) class(x)[1L], character(1L)) join_keys <- join_keys(data()) if (!is.null(join_keys)) {