Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize the use of count_pt and count_subj by count_subj #935

Open
shajoezhu opened this issue Jan 23, 2024 · 2 comments
Open

standardize the use of count_pt and count_subj by count_subj #935

shajoezhu opened this issue Jan 23, 2024 · 2 comments
Labels

Comments

@shajoezhu
Copy link
Contributor

No description provided.

@edelarua
Copy link
Contributor

@shajoezhu count_subj, count_pt, and count_events are all arguments of the same one module (tm_t_events_summary) and are flags controlling different sections of the table. Like conf_level_coxph and conf_level_survfit we could change this to a single argument that takes list input flagging which sections to display, but again that may be more confusing for users than the current behaviour.

@shajoezhu
Copy link
Contributor Author

Thanks a lot for investigating this @edelarua , I will take this off the list now and check the module again. Thanks again!

@donyunardi donyunardi removed the core label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants