Stop R process if AppDriver fails in test-examples

[averissimo]

Pull Request

Fixes #1302

[github-actions]

Unit Tests Summary

    1 files     70 suites   1h 9m 13s ⏱️
  724 tests   614 ✅ 110 💤 0 ❌
1 984 runs  1 759 ✅ 225 💤 0 ❌

Results for commit 3c2bee3.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test suite performance difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_a_gee	💚	$135.35$	$-8.36$	$0$	$0$	$0$	$0$
shinytest2-tm_a_mmrm	💚	$754.78$	$-11.18$	$0$	$0$	$0$	$0$
shinytest2-tm_g_barchart_simple	💚	$231.95$	$-5.53$	$0$	$0$	$0$	$0$
shinytest2-tm_g_forest_rsp	💚	$179.13$	$-2.32$	$0$	$0$	$0$	$0$
shinytest2-tm_g_km	💚	$268.23$	$-4.49$	$0$	$0$	$0$	$0$
shinytest2-tm_g_lineplot	💚	$87.83$	$-3.26$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_adverse_events	💚	$123.78$	$-3.00$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_patient_timeline	💚	$249.48$	$-7.74$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_therapy	💚	$199.94$	$-6.83$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_vitals	💚	$87.68$	$-1.97$	$0$	$0$	$0$	$0$
shinytest2-tm_t_abnormality	💚	$69.11$	$-3.36$	$0$	$0$	$0$	$0$
shinytest2-tm_t_abnormality_by_worst_grade	💚	$69.48$	$-1.86$	$0$	$0$	$0$	$0$
shinytest2-tm_t_ancova	💚	$98.52$	$-3.77$	$0$	$0$	$0$	$0$
shinytest2-tm_t_binary_outcome	💚	$77.65$	$-1.39$	$0$	$0$	$0$	$0$
shinytest2-tm_t_coxreg	💚	$74.71$	$-2.31$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events	💚	$63.76$	$-3.14$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events_by_grade	💚	$94.19$	$-3.88$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events_patyear	💚	$51.99$	$-1.17$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events_summary	💚	$69.40$	$-1.87$	$0$	$0$	$0$	$0$
shinytest2-tm_t_exposure	💚	$79.77$	$-1.41$	$0$	$0$	$0$	$0$
shinytest2-tm_t_logistic	💚	$60.80$	$-1.71$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_basic_info	💚	$42.10$	$-2.64$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_laboratory	💚	$129.77$	$-6.26$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_medical_history	💚	$66.75$	$-1.37$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_prior_medication	💚	$77.38$	$-1.30$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_arm	💚	$59.86$	$-2.54$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_arm_by_worst	💚	$94.13$	$-5.35$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_grade	💚	$80.77$	$-3.08$	$0$	$0$	$0$	$0$
shinytest2-tm_t_smq	💚	$60.29$	$-1.68$	$0$	$0$	$0$	$0$
shinytest2-tm_t_summary	💚	$40.12$	$-1.92$	$0$	$0$	$0$	$0$
shinytest2-tm_t_summary_by	💚	$80.90$	$-3.05$	$0$	$0$	$0$	$0$
shinytest2-tm_t_tte	💚	$68.04$	$-2.92$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
shinytest2-tm_a_mmrm	💔	$49.26$	$+1.00$	e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_lsmeans.

Results for commit 048a7c7

♻️ This comment has been updated with latest results.

[llrs-roche]

Change looks good, I guess there is no easy way to test this (without opening hundreds of failing apps).
Is this something that could affect end-users? Is it something that could be improved for them?

[averissimo]

As you correctly identified, it would not affect end-users, but it will crash systems when the conditions are there

Either the local one or even the CI if there is a consistent problem with the launched shiny app from examples.

Which conditions? Well I detected it when I didn't have the latest teal installed with the renamed teal_transform_teal_data.

Every single example app was crashing and leaving the R process open. I think it consumed 25GB before my system crashed